This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: should use copied value of iterator * fix: apply comment
feat: added WriteLowPri()
… have low priority write option
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
===========================================
+ Coverage 52.60% 65.69% +13.08%
===========================================
Files 29 32 +3
Lines 1785 1402 -383
===========================================
- Hits 939 921 -18
+ Misses 740 420 -320
+ Partials 106 61 -45
|
zemyblue
reviewed
Jan 20, 2022
0Tech
suggested changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but some improvements.
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
chore: removed duplicated line, added comments about read / write options
dudong2
approved these changes
Jan 20, 2022
0Tech
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Name() for easier debugging & and WriteLowPri() for pruning.